search

cornell-brg / pymtl

Python-based hardware modeling framework
BSD 3-Clause "New" or "Revised" License
235 stars 82 forks source link

Fix VCD generator #180

Closed orangeturtle739 closed 5 years ago

orangeturtle739 commented 5 years ago

If two signals have the same type, and are both BitStructs, and not structurally connected (i.e. with s.connect), one of them shows up as X in the generated VCD. This happened because the set of nets does not function correctly, since all the nets are Bits and all "zero". They all equal each other, and, in the case of BitStructs, have a hash function based only on their name.

cbatten commented 5 years ago

@jsn1993 Can you take a look? Seems straight-forward enough ...

cbatten commented 5 years ago

ok! @orangeturtle739 merge when ready ...