Closed JasonMun7 closed 1 week ago
[diff-counting] Significant lines: 48.
Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.
Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.
This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!
Also that sounds like a great Idea!
Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.
This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!
Also that sounds like a great Idea!
Reached out on Slack. https://cornelldti.slack.com/archives/CJCDQKR0X/p1732888246400639
Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.
This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!
Also that sounds like a great Idea!
Awesome I think I might wait on the new design and address it within this PR! Thank you so much for doing that Andrew!
Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.
This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas! Also that sounds like a great Idea!
Awesome I think I might wait on the new design and address it within this PR! Thank you so much for doing that Andrew!
I think depending on when the design gets out we could merge this in first and take it as a follow-up PR! Just to keep the PR’s small and focused and new.cornelldti.org as close to launch ready as possible.
hmm the images still seem to be moving despite the setting being on, like i said here
I know we've spent a lot of time on this, and since the animation is only so slight, I'm fine with signing off on this if we have to move on.
But just thing we can catch later on i think :) https://github.com/user-attachments/assets/5674c280-0a5b-4c93-85c8-3bf7bd43f8ff
Hmm I'm wondering if this might have to do with the hydration error as it seems to work fine on my local machine. I think i'll move on for now until we get through the pages/hydration error. Thanks @Bookie0 !
@JasonMun7 ok sounds good!
Summary
This PR addresses the following changes for the products page
Notion/Figma Link
This was updated after talking with @Bookie0!! Reduce Motion Replace logos
Test Plan
Before sizing and spacing:
After Sizing and spacing:
Notes
ProductDisplay
component since each image in the figma has different width limits