Closed JonathanWenger closed 1 year ago
It seems like there are some inconsistencies in the import formatting in the current library. Let me know if you're fine with me just reformatting the imports in this PR.
How do you (and @gpleiss, @jacobrgardner) feel about using µfmt (https://ufmt.omnilib.dev/en/stable/)? This takes care of the conflicts between black and isort, we've been using it without issues in BoTorch for a long time now.
I am 100% in favor of any dev practices you all use for BoTorch :)
Done in #56.
In a Nutshell
Configuration between linters
isort
andblack
was only handled in pre-commit hooks and could lead to conflicts.In Detail
When running pre-commit hooks and also locally installing black via the instructions in
CONTRIBUTING.md
one could end up with different versions / settings leading to reformatting from the pre-commit hooks every commit. I also fixed the exclusions in the pre-commit configuration along the way, since it was throwing warnings: