Update scripts for 1.6.2 release

corretto / amazon-corretto-crypto-provider

The Amazon Corretto Crypto Provider is a collection of high-performance cryptographic implementations exposed via standard JCA/JCE interfaces.

Apache License 2.0

238 stars 56 forks source link

Update scripts for 1.6.2 release #268

Closed amirhosv closed 1 year ago

amirhosv commented 1 year ago

Description of changes:

Update OpenSSL to 1.1.1t
Fix some integration tests
Use cmake3 to build

Testing:

./gradlew -Dorg.gradle.internal.http.socketTimeout=300000 build src_jar javadoc test test_integration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

WillChilds-Klein commented 1 year ago

looks like codebuild is trying to run integration tests that we didn't add until 2.0

[Container] 2023/02/13 16:42:54 Phase is DOWNLOAD_SOURCE
--
[Container] 2023/02/13 16:42:54 CODEBUILD_SRC_DIR=/codebuild/output/src357300428/src/github.com/corretto/amazon-corretto-crypto-provider
[Container] 2023/02/13 16:42:56 Phase complete: DOWNLOAD_SOURCE State: FAILED
[Container] 2023/02/13 16:42:56 Phase context status code: YAML_FILE_ERROR Message: stat /codebuild/output/src357300428/src/github.com/corretto/amazon-corretto-crypto-provider/tests/ci/codebuild/run_accp_basic_tests.yml: no such file or directory

amirhosv commented 1 year ago

I thought CI tasks are configured for branches but it seems they run for each PR regardless of the target branch.

WillChilds-Klein commented 1 year ago

can we configure which CI checks are required using per-branch branch protection rules?

you might try just adding all the codebuild. configuration to the branch. because the test code for 1.6 is still on this is branch and 1.6 (unofficially) supported ARM, i'd expect the only CI checks to fail to be MacOS.