search

corretto / corretto-8-docker

Dockerfiles for Amazon Corretto 8
MIT No Attribution
195 stars 40 forks source link

move rpm names to arguments #8

Closed ajayk closed 6 years ago

ajayk commented 6 years ago

Issue #, if available:

Description of changes: move rpm names to arguments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

EricEdens commented 6 years ago

Hi, @ajayk , the RPM is now available directly from Amazon Linux's yum repository, so we've simplified the Dockerfile. With this simplification, we don't need to hardcode the RPM full names, so it avoids the refactoring that you have here.

https://github.com/corretto/corretto-8-docker/commit/c6140fa3a1c56a1b44eda030cac997869c43d283

ajayk commented 6 years ago

Thanks @EricEdens Makes it much simpler !!