corridor / configurable-http-proxy

A pure python alternative for configurable-http-proxy
Apache License 2.0
14 stars 7 forks source link

JupyterHUB: progress API updates blocked by configurable-http-proxy #17

Open lflis opened 1 year ago

lflis commented 1 year ago

Hi. JupyterHUB 4.0.2, CHP 0.3.0 Recently we came across the problem where progress page in jupyterhub was not updated until notebook spawning was complete.

We have narrowed down the issue to CHP blocking chunked-responses from jupyterhub api until response generation is complete. What's more, request times out after 20 seconds.

progress API is using keep-alive connection and sends chunked response to the client. It is based on XHR connection (event-type/stream). CHP here:

This functionaly works properly in NPM counter part.

AbdealiLoKo commented 1 year ago

Hi thanks the the report - did a quick check and seems like I can reproduce the issue

Would you like to attempt a fix with a PR?

lflis commented 1 year ago

@AbdealiLoKo thank you for confirming the issue.

Would you like to attempt a fix with a PR?

Unfortunately i don't have a quickfix nor PR yet. I'm not very familiar with CHP architecture either so it may take some time for me to come up with a camera ready solution.

I guess you might have better idea on sensible fix it so feel free to patch.