search

cosimoNigro / agnpy

Modelling jetted Active Galactic Nuclei radiative processes with python
https://agnpy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 33 forks source link

fixed wrong parameter extraction from the EC sherpa fit tutorial notebook #72

Closed jsitarek closed 3 years ago

jsitarek commented 3 years ago

variable has be extracted from the fit under wrong name in calc function of cell [5],

since it was also defined as global the bug (found by @pawel21) did not have effect on results

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (91240a9) into master (c8aa09f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files          30       30           
  Lines        1725     1725           
=======================================
  Hits         1611     1611           
  Misses        114      114
Flag Coverage Δ
unittests 93.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8aa09f...91240a9. Read the comment docs.