cosmicds / cds-api

API for accessing the CosmicDS database
GNU General Public License v3.0
0 stars 3 forks source link

Update status codes for stage 3 data endpoints #75

Closed Carifio24 closed 1 year ago

Carifio24 commented 1 year ago

Currently, the /stage-3-data endpoints return a 404 if the found set of measurements is empty. This made sense in the original implementation, where this meant that no data for the student or student/class combo existed. But now that we only return data if there's been a change since we last checked, this doesn't really make sense - getting no data returned can happen (quite frequently) with valid inputs. This PR updates the status code for these endpoints to only give a 404 if one or more of the passed IDs is invalid.