cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
553 stars 597 forks source link

imp: use error returns in VerifyMembership fns #7492

Closed colin-axner closed 1 month ago

colin-axner commented 1 month ago

Description

made this change in relation to https://github.com/cosmos/ics23/pull/391

Example error message now:

failed to verify membership proof at index 0: provided value doesn't match proof: invalid proof

Previous error message:

chained membership proof failed to verify membership of value: 696E76616C69642076616C7565 in subroot FED126FA5980E8E5261C96B693BB0DB1999AA07C23CD5A53F23D59340A3F4A1C at index 0. Please ensure the path and value are both correct.: invalid proof

closes: #183


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
149 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud