cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
553 stars 597 forks source link

fix: channel must exist before channel creator check #7538

Closed gjermundgaraba closed 3 weeks ago

gjermundgaraba commented 3 weeks ago

Description

Noticed a bit of bad DX when I was sending in the wrong channel-id to register counterparty. Since it was checking the creator first, I got creator not found, when the real issue was that the channel id was not correct (channel not found). Moved the check up and adjusted the test to catch this.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud