Noticed a bit of bad DX when I was sending in the wrong channel-id to register counterparty. Since it was checking the creator first, I got creator not found, when the real issue was that the channel id was not correct (channel not found). Moved the check up and adjusted the test to catch this.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.
Description
Noticed a bit of bad DX when I was sending in the wrong channel-id to register counterparty. Since it was checking the creator first, I got creator not found, when the real issue was that the channel id was not correct (channel not found). Moved the check up and adjusted the test to catch this.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.