fix: packet keys corrupted

gjermundgaraba commented 2 weeks ago

Description

I think we will change the format to use bytes later (?), but the current setup gave problems because the byte array for big endian didn't stringify very well. So until we get the packet keys sorted, this will at least work.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gjermundgaraba commented 2 weeks ago

Close in favor of https://github.com/cosmos/ibc-go/commit/00505238557a6d9eab1013e07e43a75f401680f8

cosmos / ibc-go

fix: packet keys corrupted #7546

Description

Quality Gate passed for 'ibc-go'