search

coto / gae-boilerplate

Google App Engine Boilerplate
https://dev-dot-sandengine.appspot.com/
Other
684 stars 187 forks source link

Integration with Github #146

Closed kordless closed 12 years ago

kordless commented 12 years ago

Would be awesome to have oauth integration with github. I'm trying to figure this out right now and if I get it working, would like to contribute it back to the project...

coto commented 12 years ago

I am agree. Your idea is pretty good, if you can do it, great. Don't forget to use the same handlers of other third party authentications. On Sep 26, 2012 11:00 PM, "Kord Campbell" notifications@github.com wrote:

Would be awesome to have oauth integration with github. I'm trying to figure this out right now and if I get it working, would like to contribute it back to the project...

— Reply to this email directly or view it on GitHubhttps://github.com/coto/gae-boilerplate/issues/146.

kordless commented 12 years ago

On another topic, I have an alternate signup flow implemented. It's here: http://tinyprobe.com/. If you like it, I could merge my changes in once the move to the new directory goes down. Trying to juggle my auth changes

Cheers!

Kord

On Wed, Sep 26, 2012 at 7:04 PM, coto notifications@github.com wrote:

I am agree. Your idea is pretty good, if you can do it, great. Don't forget to use the same handlers of other third party authentications. On Sep 26, 2012 11:00 PM, "Kord Campbell" notifications@github.com wrote:

Would be awesome to have oauth integration with github. I'm trying to figure this out right now and if I get it working, would like to contribute it back to the project...

— Reply to this email directly or view it on GitHub< https://github.com/coto/gae-boilerplate/issues/146>.

— Reply to this email directly or view it on GitHubhttps://github.com/coto/gae-boilerplate/issues/146#issuecomment-8916900.

peta15 commented 12 years ago

Hi @kordless :

I love what you have done with the boilerplate. I tested out your site signup workflow. I like the two step process. I'm a huge fan of requesting as little mandatory info as possible from users on signup to avoid intimidation and i think you are heading in the right direction. One of the main considerations is how the workflow also works with openid/oauth. What i envision for both email/username and openid/oauth signup is a two step process similar to what you have:

In any case signup workflow is always non-trivial and different projects have different needs so if its possible for you to add your workflow without completely killing the current one (maybe some config option to switch between it and the current workflow) then that would probably make people happy. Just my thoughts here... it may be too much work right now - up to you.

Regarding github oauth - do you mean adding a button to login via your github account?

I think your front page layout is very pro looking. I see a lot of sites using bootstrap that look like this. It would be great to mirror some of the layout you have used - ie the dark area at the bottom with the sitemap (on the boilerplate we could take what we have in that sub bar (contact page, signup page, forgot password etc) and put those links in the map. We could also take our copy and shade it too.

Finally just a few quick questions:

  1. what would you say to adding a link to your site in the boilerplate readme under a subsection called example sites ? this would inspire users to adopt the boilerplate and give the contributors insight into its use and in return you will get more traffic
  2. what do you think of the directory structure change made recently - putting all the boilerplate files in a boilerplate directory? With regard to how you are using the boilerplate and keeping your site updated with changes from the boilerplate do you think this change will make the updates easier for you? But will you have to custom modify some boilerplate files anyway which would detract from this design change? Is there some compromise we haven't thought of that would work best?
  3. I see you dont have internationalization or openid. Are you using the config options i added that allow you to disable/hide them or did you end up stripping out the code?

Thanks! I really appreciate the insight. I think getting this kind of feedback and contribution will help move this project in the best direction.

kordless commented 12 years ago

Howdy!

First off, you guys rock. Really, really wonderful you've done this for the rest of us. Thank you.

I agree with the need for flexibility. What works for my site may not work for others. We already have a good way of handling this via templates, so my proposal would be to create a few new workflows using new templates and add those in to the main project. Changes to the signup workflow could be selected by the user in the routes.py file.

Regarding openid 'registrations': The reason I pulled out openid registration is because I'll be charging for the service and felt that email validation would need to be the first step in the registration flow. I left in the provider associations in the user's profile (at least for Google and Twitter) so users could tie those accounts to the service I'm building. The only other component I need for this is an oauth association to Github - I need to be able to pull user's gists. Honestly I'm just looking at how the LinkedIn stuff was done and trying to build the Github module using that code as a starting point. I'm a bit out of my element with oauth, but I grok how it's being done, so should be able to muddle through ok over the next few days.

I still have the internationalization stuff in there, but because of the type of project I'm doing, it's unlikely I'll use it anytime soon. Trying to keep using the translation-enabled strings though. Used a similar technique when we internationalized Zoto, now I think about it. Good stuff!

I'm pleased you like the look and feel of the site. I'm more than happy to contribute my CSS and edits to the main page template to the project. I don't want to poke the bear, but some template theme selection may eventually be in order. I'll be happy to whip this (and the alternate signup flow up) once you guys finish your merge for the directory restructure.

I'm the sole coder for TinyProbe. I'm intentionally bootstrapping it, not planning on raising money. As things go, I'm cycling through the project every few weeks. Work on CSS/layout, move to UX, then to backend, rinse and repeat. As soon as I get back around the site pages (about us, docs, pricing) I'd be more than happy to let you mention the site! Say a few weeks tops OK?

On Wed, Sep 26, 2012 at 10:05 PM, Jesse Goodall notifications@github.comwrote:

Hi @kordless https://github.com/kordless :

I love what you have done with the boilerplate. I tested out your site signup workflow. I like the two step process. I'm a huge fan of requesting as little mandatory info as possible from users on signup to avoid intimidation and i think you are heading in the right direction. One of the main considerations is how the workflow also works with openid/oauth. What i envision for both email/username and openid/oauth signup is a two step process similar to what you have:

  • step 1 request just the minimum info: an email OR a username and/or email and password OR openid/oauth token (ie a unique token granted when the user authenticates on an openid provider like google).
  • step 2 a form with optional (and possibly some mandatory) fields dictated by the needs of the project using the boilerplate (ie other user info). on step 2 a skip button could be included or the entire step skipped with a config option for applications that want the fastest possible signup. The idea being the user is encouraged to fillout info on signup but also encouraged to come back to it later if doing so now would discourage them from finishing the signup process.

In any case signup workflow is always non-trivial and different projects have different needs so if its possible for you to add your workflow without completely killing the current one (maybe some config option to switch between it and the current workflow) then that would probably make people happy. Just my thoughts here... it may be too much work right now - up to you.

Regarding github oauth - do you mean adding a button to login via your github account?

I think your front page layout is very pro looking. I see a lot of sites using bootstrap that look like this. It would be great to mirror some of the layout you have used - ie the dark area at the bottom with the sitemap (on the boilerplate we could take what we have in that sub bar (contact page, signup page, forgot password etc) and put those links in the map. We could also take our copy and shade it too.

Finally just a few quick questions:

  1. what would you say to adding a link to your site in the boilerplate readme under a subsection called example sites ? this would inspire users to adopt the boilerplate and give the contributors insight into its use and in return you will get more traffic
  2. what do you think of the directory structure change made recently - putting all the boilerplate files in a boilerplate directory? With regard to how you are using the boilerplate and keeping your site updated with changes from the boilerplate do you think this change will make the updates easier for you? But will you have to custom modify some boilerplate files anyway which would detract from this design change? Is there some compromise we haven't thought of that would work best?
  3. I see you dont have internationalization or openid. Are you using the config options i added that allow you to disable/hide them or did you end up stripping out the code?

Thanks! I really appreciate the insight. I think getting this kind of feedback and contribution will help move this project in the best direction.

— Reply to this email directly or view it on GitHubhttps://github.com/coto/gae-boilerplate/issues/146#issuecomment-8925986.

kordless commented 12 years ago

Apologies for taking this thread off topic.

coto commented 12 years ago

Don't worry Korn for taking this thread off topic.

I think merge your github auth and the front end work with the boilerplate would be absolutely great.

Right now @tmayr is moving all the CSS to less and match the front end with the latest version of twitter bootstrap. I would recommend you wait until he push those changes and then put your code.

Thanks again for your feedback.

@coto On Sep 27, 2012 12:31 PM, "Kord Campbell" notifications@github.com wrote:

Apologies for taking this thread off topic.

— Reply to this email directly or view it on GitHubhttps://github.com/coto/gae-boilerplate/issues/146#issuecomment-8940260.