search

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)
https://www.couchbase.com/
Apache License 2.0
243 stars 110 forks source link

fixed bug in code example of lock() #26

Closed rbaier closed 9 years ago

rbaier commented 10 years ago

The code example in the comment of lock() didn't work. Without the 'break' the loop goes on and on and tries again to lock the key which will fail with TemporaryFailError.

brett19 commented 9 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit, accept our CLA and push your change there. More detailed instructions are available here: https://developer.couchbase.com/open-source-projects#how-to-contribute-code.

P.S. Our bot tells us you are currently unregistered on Gerrit.

rbaier commented 9 years ago

Well, then better keep the wrong example.

mnunberg commented 8 years ago

http://review.couchbase.org/62960