search

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)
https://www.couchbase.com/
Apache License 2.0
243 stars 110 forks source link

GEventIOEvent, GEventTimer calls super constructor #35

Closed sublee closed 7 years ago

sublee commented 7 years ago

To make it work with couchbase_ffi, GEventTimer should have _cdata attribute which is initialized by couchbase_ffi.iops.Event.__init__(). But GEventTimer didn't call its super constructor.

cb-sdk-robot commented 7 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

Your changes (commit: 97c3d249cca6d0089b5cd37165a4a071223368f4) have been pushed to the Couchbase Review Site: http://review.couchbase.org/78906

::SDKBOT/PR:created

sublee commented 7 years ago

@ingenthr Please assign a reviewer.

cb-sdk-robot commented 7 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged

sublee commented 7 years ago

@mnunberg Thank you for starting to review it!

sublee commented 7 years ago

Oh, has it done?

mnunberg commented 7 years ago

Yep :) all good

On Jun 4, 2017, at 11:06 PM, Heungsub Lee notifications@github.com wrote:

Oh, has it done?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/couchbase/couchbase-python-client/pull/35#issuecomment-306110778, or mute the thread https://github.com/notifications/unsubscribe-auth/AAanUdCuiEyVcCmEQzW7JRqKJZqugNRLks5sA5r0gaJpZM4Ns5ki.

sublee commented 7 years ago

@mnunberg Thank you for merging my work.

I'll also write a merge request on couchbase-python-cffi soon. I guess you have already heard about my story from @ingenthr.