search

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)
https://www.couchbase.com/
Apache License 2.0
243 stars 110 forks source link

Add optionally loop param in acouchbase.Bucket #36

Closed Sharpek closed 7 years ago

cb-sdk-robot commented 7 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: sh***ek@sha*****net

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

Sharpek commented 7 years ago

@lphuberdeau Agree, changed.

On 29.06.2017 13:45, Louis-Philippe Huberdeau wrote:

@lphuberdeau commented on this pull request.

In acouchbase/bucket.py https://github.com/couchbase/couchbase-python-client/pull/36#discussion_r124777565:

@@ -11,7 +11,10 @@

class Bucket(AsyncBucket): def init(self, *args, **kwargs):

  • loop = asyncio.get_event_loop()
  • loop = kwargs.pop('loop', None)

How about:

|def init(self, *args, loop, **kwargs): loop = loop or asyncio.get_event_loop() |

This way, kwargs does not get altered and the code is a little more explicit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/couchbase/couchbase-python-client/pull/36#pullrequestreview-47098605, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdA2ba8TZB_62K0r5UJfWH4oEWUA4gWks5sI45MgaJpZM4OJLK3.

cb-sdk-robot commented 7 years ago

Unfortunately it has been 7 days and we are still unable to confirm that you have signed our CLA. We sincerely appreciate your submission and hope that you will register and resubmit this Pull Request in the future!

::SDKBOT/PR:timeout