search

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)
https://www.couchbase.com/
Apache License 2.0
243 stars 110 forks source link

Some errors don't have a 'key'. Gracefully degrade. #39

Closed djeebus closed 6 years ago

djeebus commented 6 years ago

The test should show what I'm talking about. Specifically I'm using:

ubuntu 18.04 python 3.6.5 libcouchbase-dev 2.9.5-1 couchbase Community Edition 5.1.1 build 5723

not quite sure why some ViewResults don't have key attributes, but this seems to fix it.

cb-sdk-robot commented 6 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: ***@dje*****net

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

cb-sdk-robot commented 6 years ago

Your changes (commit: c4bb6ada3b237b9bfbce7f541a9285bcc8a55aa8) have been pushed to the Couchbase Review Site: http://review.couchbase.org/99953

::SDKBOT/PR:created

griels commented 6 years ago

Hi @djeebus - please could you sign the CLA today if possible, as I would like to get a fix reusing your test into the release today?

Many thanks,

Ellis

djeebus commented 6 years ago

@griels I believe I signed it a week ago? The website claims "Agreement already submitted."

ingenthr commented 6 years ago

@griels I believe I signed it a week ago? The website claims "Agreement already submitted."

The most common reason that it may not be matching up is using a different email address on the gerrit account from your PR. The bot gave an anonymized email to check matching above-- do they match?

Check http://review.couchbase.org/#/settings/ and http://review.couchbase.org/#/settings/contact .

Thanks for working through this necessary step!

djeebus commented 6 years ago

Yup, the anonymized email address looks to be the same as the one in gerrit. Anything else I should check?

griels commented 6 years ago

Adapted and merged. Thanks for your contribution.

griels commented 6 years ago

Adapted and merged. Thanks for your contribution.

griels commented 6 years ago

Have adapted your test and written a new implementation. Thanks for your contribution!

djeebus commented 6 years ago

Happy to help, thanks for merging!