search

couchbase / kafka-connect-couchbase

Kafka Connect connector for Couchbase Server
https://issues.couchbase.com/projects/KAFKAC
Apache License 2.0
73 stars 72 forks source link

Added filter and converter infrastructure. #2

Closed allotria closed 8 years ago

allotria commented 8 years ago

I added a simple infrastructure to plug-in filters and converters.

The filters are inspired by your earlier couchbase-kafka-connector.

avsej commented 8 years ago

Hi @allotria, thanks for the pull request!!

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Note: Please contact us if you have any issues registering with Gerrit!

allotria commented 8 years ago

I accepted the CLA in Gerrit. Do I need to print, sign, scan and mail it to you or does it count when I wrote "I ACCEPT" into the form?

allotria commented 8 years ago

I fixed your code review change requests.

avsej commented 8 years ago

Thank you @allotria