Closed werkins closed 5 years ago
Thank you for the contribution. Please let us know if you have any difficulty creating a Gerrit account.
If you've already created an account, please make sure the email address associated with your Gerrit account is the same as the email associated with this PR (rs****no@atsi******.com
). You can associate additional email addresses with your Gerrit account in the Gerrit settings.
Your changes (commit: d622675adf4f0c9bd0198ad6591987d83302a22a) have been pushed to the Couchbase Review Site: http://review.couchbase.org/93330
::SDKBOT/PR:created
@werkins, I left review notes on gerrit change, could you update the patch there?
Your changes (commit: 67e8c2571c0e9fc48b7c8ebe427e011a7d22d131) have been pushed to the Couchbase Review Site: http://review.couchbase.org/93330
Note: As your pull request contains multiple commits, we have performed an automatic squash of these commits into a single change-set. If this is not the desired behaviour, please consider submitting a pull request per discreet feature.
::SDKBOT/PR:updated
@werkins, please use gerrit to update the patch.
Your changes (commit: b3044195efe47e8123346684f342ad750f49dd8e) have been pushed to the Couchbase Review Site: http://review.couchbase.org/93330
Note: As your pull request contains multiple commits, we have performed an automatic squash of these commits into a single change-set. If this is not the desired behaviour, please consider submitting a pull request per discreet feature.
::SDKBOT/PR:updated
Your changes (commit: 740d14c24c8342747c22bb89797d1964cbf1f9cf) have been pushed to the Couchbase Review Site: http://review.couchbase.org/93330
Note: As your pull request contains multiple commits, we have performed an automatic squash of these commits into a single change-set. If this is not the desired behaviour, please consider submitting a pull request per discreet feature.
::SDKBOT/PR:updated
@werkins github will not help you to create the patch for review properly. You have to use gerrit to submit updates.
Hi @werkins,
Just wanted to see if you were able to make the changes mentioned over on the Gerrit PR. Let us know if you want help with Gerrit or something else.
Thanks, David
I'm sorry guys, but I've been lately too busy to polish the code. Most of the work is already done, just need to find a couple of hours for it (still difficult, though)
This Pull Request has been closed as the associated Gerrit change was abandoned.
::SDKBOT/PR:abandoned
Closing due to inactivity. We appreciate the work you put into this, and would be happy to pick it up again if you'd like to resume working on it in the future.
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.
To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.
Keep in mind that the emails we are seeing on the commits are:
rs****no@atsi******.com
Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.
::SDKBOT/PR:no_cla