coverallsapp / github-action

Coveralls Github Action
https://github.com/marketplace/actions/coveralls-github-action
MIT License
469 stars 74 forks source link

"Some checks were not successful" even if they were #95

Open PaulRBerg opened 3 years ago

PaulRBerg commented 3 years ago

I am running the Coveralls GitHub action in a monorepo, setting the parallel flag to true so that I can run the coverage jobs in parallel and batch-upload them at the end of the GitHub workflow execution. Here's my integration script:

https://github.com/hifi-finance/hifi/blob/10e8767c3749a3bf6a5cfe2c1c151df5935be87a/.github/workflows/integration-contracts.yaml

The issue is that occasionally, even if the workflow executes successfully, the Coveralls integration shows a red cross icon on the main page of the repository:

hifi-finance/hifi red cross

The error being:

Some checks were not successful

But the checks are successful! If I take this CI execution as an example, we can see it ran as expected:

https://github.com/hifi-finance/hifi/actions/runs/1270454967

The error seems to indicate that the "flash-swap" and the "protocol" jobs failed somehow. But if I look them up:

I can see no error in the Coveralls website. This might be a bug in the GitHub integration of Coveralls when the coverage reports are uploaded in parallel.

pcolby commented 2 years ago

I have a similar (same?) issue... if you mouse-over the red cross, the tooltip will give you the reason for the "failure". In my case, it claims that the code coverage dropped, yet if I go to the link in Coveralls, it says "coverage remained the same". Is that what you're seeing too, or a different issue?