covid-alert-ny / covid-green-app

Covid Alert NY - React-Native App
Apache License 2.0
6 stars 1 forks source link

Revert "Better universal workaround for iOS spinner bug (#643)" #644

Closed AlanSl closed 3 years ago

AlanSl commented 3 years ago

This reverts commit ef8a042a19a5c63932a07a0e4e5b436adffc6bd9

https://github.com/covid-alert-ny/covid-green-app/pull/643 improved things in local builds but in a QA build it actually made the spinner issues worse ( https://github.com/covid-alert-ny/covid-green-app/issues/627#issuecomment-782301479 ) so let's revert it. The new issues involve the app restarting or starting from closed so probably something about the time taken to download JS from Metro on app start in local builds is causing the difference.

The issues passed QA testing before, there was just a lag and the theoretical possibility of the spinner issue cropping up elsewhere, but that's better than spinner issue actually cropping up that can't be reliably replicated in local React Native builds.