covid-policy-modelling / web-ui

Frontend for COVID modeling
MIT License
0 stars 2 forks source link

Removed command --default-authentication-plugin=mysql_native_password in docker-compose.yml #60

Closed MarShaikh closed 5 months ago

MarShaikh commented 5 months ago

Solves #59 Issue seems related to default_authentication_plugin being deprecated in versions 8.4+ as per the updates. If it is necessary to keep this line, it would be a better idea to fix the image version to 8.0 instead.

sdwfrost commented 5 months ago

It doesn't seem to fix the problem on my machines (WSL and OSX); probably just some odd Docker/VPN issues. Pinning the mysql container to 8.0 or 8.4 (with command command: --mysql-native-password=ON instead) is probably the way to go.

MarShaikh commented 5 months ago

It doesn't seem to fix the problem on my machines (WSL and OSX); probably just some odd Docker/VPN issues. Pinning the mysql container to 8.0 or 8.4 (with command command: --mysql-native-password=ON instead) is probably the way to go.

Probably sounds like it. Because this change started working on my machine(OSX too).

sdwfrost commented 5 months ago

I got it working on Mac, when I used Docker Desktop; previously, I was using colima. Here are my suggested edits:

  1. Pin the mysql image to 8.4.
  2. Change the command to command: --mysql-native-password=ON
  3. Make a note in the README.md that this does not work out of the box using colima on Mac, while I sort out a fix.