search

cowboy / synology-update-plex

Script to Auto Update Plex Media Server on Synology NAS
113 stars 22 forks source link

Update update-plex.sh #10

Closed sodhi closed 4 years ago

sodhi commented 4 years ago

Not all versions of wget (which differs between DSM versions) support "--no-show-progress", but "-q" always works (afaik). Your version fails on i.e. DSM 6.1.7.

cowboy commented 4 years ago

Well, --quiet (-q) and --no-show-progress have different outputs, and I don't want it to be completely silent. What version does wget --version output for you?

cowboy commented 4 years ago

What does this command output for you?

wget --no-verbose https://downloads.plex.tv/plex-media-server-new/1.19.1.2701-6327e27bf/synology/PlexMediaServer-1.19.1.2701-6327e27bf-x86.spk -P /tmp
sodhi commented 4 years ago

--no-verbose:

sodhi@NAS $ wget --no-verbose https://downloads.plex.tv/plex-media-server-new/1.19.1.2701-6327e27bf/synology/PlexMediaServer-1.19.1.2701-6327e27bf-x86.spk -P /tmp

2020-04-28 13:34:06 URL:https://downloads.plex.tv/plex-media-server-new/1.19.1.2701-6327e27bf/synology/PlexMediaServer-1.19.1.2701-6327e27bf-x86.spk [100341760/100341760] -> "/tmp/PlexMediaServer-1.19.1.2701-6327e27bf-x86.spk.1" [1]

--version

GNU Wget 1.15 built on linux-gnu.

+digest +https +ipv6 -iri +large-file -nls +ntlm +opie +ssl/openssl

cowboy commented 4 years ago

Ok. Update your PR to change --no-show-progress to --no-verbose instead of -q and I'll merge it! Note: you'll also need to remove the | awk '!/--| saved |^$/' bit at the end of the line, since that's no longer relevant.

cowboy commented 4 years ago

I suppose the line should just be

wget --no-verbose "$package_url" -P $tmp_dir
sodhi commented 4 years ago

Done. I hope correctly. Not too used to github ;-)