Improve Rendering and Functionality of Settings Page

coyote-team / coyote-wp

Wordpress Plug-in for Coyote

2 stars 2 forks source link

Improve Rendering and Functionality of Settings Page #94

Closed Pen-a11y closed 2 years ago

Pen-a11y commented 2 years ago

The way that WordPress traditionally handles a settings page could lead to code that is messy, and hard to read.

To improve the functionality of the Settings Page we need to create a configuration model layer, that uses Twig templates and JavaScript to improve the rendering and functionality of the pages.

jkva commented 2 years ago

This supersedes #21.

Effectively:

Split up Coyote Settings into its own sidebar menu, with the sub-items "Settings" and "Tools"
Use Twig (or another time-proven PHP templating engine) for view rendering
Optionally generate a ViewModel which feeds into the settings view, perhaps also tools
Move the setting "API endpoint" into advanced settings, defaulting to the live endpoint

jkva commented 2 years ago

The templating engine item has been split to #117.

jkva commented 2 years ago

The "API endpoint to advanced settings" item will remain a separate issue as #113.

robbinrietdijk commented 2 years ago

In first review with @jkva decided to refactor array arguments in actions and filters to braces "[]" instead of "array()". Will work this out before creating a Pull Request.

jkva commented 2 years ago

Closing as addressed via #118.