Cardback Crop - Githubissues

cozuya / secret-hitler

A web adaptation of the social deduction board game Secret Hitler. https://secrethitler.io

Other

841 stars 202 forks source link

Cardback Crop #1945

Closed davejab closed 2 years ago

davejab commented 2 years ago

Changes

Allows users to crop image before saving as cardback
Prevents squashed/distorted cardbacks

Screenshots

Screenshot from 2022-02-17 14-49-49

Tested Locally

[x] This PR has been tested locally, and ensured to not cause any breaking changes

Tests

[x] This PR does not require tests

Changelog

[x] Changelog Section below has been updated with Changelog entry

Changelog Entry

[x] New Feature
[x] Minor Change

Changelog Headline: Added cardback cropper

Changelog Details: Users can now resize and crop an image when setting their cardback

davejab commented 2 years ago

closes #1944

iounpaladin commented 2 years ago

Thanks for this! This looks really cool. Unfortunately there are some large changes that are unmerged in Settings.jsx, so I'll review + merge once those are in.

iounpaladin commented 2 years ago

Thanks for the updates, I'll review + test tomorrow :D

davejab commented 2 years ago

I'm just curious if there's a way to allow "backwards compatibility," if you will.

I have pushed https://github.com/cozuya/secret-hitler/pull/1945/commits/dafb6eae43677a14c84e3783ef622076b68a3d9b which allows the crop box to be resized meaning you can re-scale images.

Settings.jsx has been updated, so if you could address the merge conflicts that would be great, thank you!

Resolved with https://github.com/cozuya/secret-hitler/pull/1945/commits/cd1b909357bc7c24231be67495de262842756ee8.