Remove animations when displaying a message

[frankrousseau]

When I click on a message to read it, I don't have a consistent behavior on the way it is displayed. Sometimes, it slides from the right sometimes, it just changes the message.

I will try to explain it better later. I open the issue to initiate the conversation about this.

[clochix]

I'm aware of this behavior, and know the reasoning behind it (when the right pan isn't shown, it slides on open. Then, messages are just updated inside the pane).

I would suggest removing the sliding effect to be more consistent.

@jsilvestre, any objection?

[clochix]

Ping @frankrousseau, what about removing the sliding effect when opening the right panel?

[frankrousseau]

Yes remove it! Common operations like opening an email should be as fast as possible.

[poupotte]

Message displaying is better without animations. Thanks @clochix .

it will be available in version 0.6.8

[frankrousseau]

The animation is still there.

[poupotte]

Yes, it stay a little animation during mail openning for the first time, I didn't see it.

[jsilvestre]

I have found references to the opening animations in the code:

• https://github.com/cozy/cozy-emails/blob/master/client/app/styles/_layout.styl#L93-L104
• https://github.com/cozy/cozy-emails/blob/master/client/app/styles/_message-list.styl#L13-L15
• https://github.com/cozy/cozy-emails/blob/master/client/app/styles/_compose.styl#L9-L11
• https://github.com/cozy/cozy-emails/blob/master/client/app/components/application.coffee#L193-L213

After removing them locally, I'm not sure I see a difference. That can mean two things:

• there are still animations, but I don't know where they come from
• OR those animations were useless
• (or that I'm blind).

Do you want me to push those changes in my currently opened PR? @clochix

[clochix]

Thanks a lot @jsilvestre, I forgot to remove this one. I agree with you, I don't see any difference. I just committed, the removal, will be in my next PR.

[frankrousseau]

@clochix Do not forget to not make too big PR.

[poupotte]

Effectively, animations still exists but they're fast and if you don't know where they come from, I'm not sure is in our priority. I propose to put this issue in our backlog (not again in our next sprint). What do you think @frankrousseau ?

[frankrousseau]

Ok.