cp2004 / OctoPrint-WS281x_LED_Status

Add some RGB LEDs to your printer for a quick status update!
https://plugins.octoprint.org/plugins/ws281x_led_status
GNU Affero General Public License v3.0
111 stars 26 forks source link

Startup effect don't run sometimes #149

Closed IzK666 closed 3 years ago

IzK666 commented 3 years ago

If you shutdown octoprint while the printer is idle with the lights out, the startup effect don't show up. Before adding this effect I would recommend to add some single run effects that don't repeat unendless.

cp2004 commented 3 years ago

If you shutdown octoprint while the printer is idle with the lights out, the startup effect don't show up.

This is working as intended - the lights status (on/off) is persisted across restart of OctoPrint. The change here is working around this, for a specific effect, and is doing the opposite by just always enabling the lights.

IzK666 commented 3 years ago

It enables the lights only if the idle setting is on, not always. Otherwise, the startup effect don't run

cp2004 commented 3 years ago

Yes but this is still counter-intuitive, and the plugin is working as intended. If you turn the lights on again after server startup, you find the startup effect.

If you are making this change because you want the lights to turn back on when you restart OctoPrint, then instead there should be a setting for 'save lights on/off state across restarts' that you can disable. Not bypassing this feature.