search

cppalliance / http_proto

HTTP/1 parsing and serialization algorithms using C++11
https://develop.http-proto.cpp.al/
Boost Software License 1.0
23 stars 10 forks source link

Update status code list to conform with IANA registry #63

Closed ashtum closed 7 months ago

ashtum commented 7 months ago

https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://63.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://63.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://63.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3de809f) 85.11% compared to head (2608657) 85.18%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cppalliance/http_proto/pull/63/graphs/tree.svg?width=650&height=150&src=pr&token=IoZbqjUnBr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance)](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #63 +/- ## =========================================== + Coverage 85.11% 85.18% +0.06% =========================================== Files 77 77 Lines 4200 4199 -1 =========================================== + Hits 3575 3577 +2 + Misses 625 622 -3 ``` | [Files](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [src/status.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL3N0YXR1cy5jcHA=) | `90.80% <100.00%> (+3.30%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [3de809f...2608657](https://app.codecov.io/gh/cppalliance/http_proto/pull/63?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).
vinniefalco commented 7 months ago

Suggested commit message: "status codes are IANA conforming"

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://63.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://63.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://63.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cmazakas commented 7 months ago

Btw, don't worry about the CI failures. That's something I've already fixed in my PR here.

In hindsight, using the output of the action isn't as nice compared to just using the hard-coded path where we know vcpkg is going to live.