search

cppalliance / http_proto

HTTP/1 parsing and serialization algorithms using C++11
https://develop.http-proto.cpp.al/
Boost Software License 1.0
23 stars 10 forks source link

Make `source` a nested type of `serializer` #74

Closed ashtum closed 6 months ago

cppalliance-bot commented 6 months ago

An automated preview of the documentation is available at https://74.http-proto.prtest.cppalliance.org/libs/http_proto/doc/html/index.html

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.09%. Comparing base (39a71bf) to head (ef7098e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cppalliance/http_proto/pull/74/graphs/tree.svg?width=650&height=150&src=pr&token=IoZbqjUnBr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance)](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #74 +/- ## ======================================== Coverage 88.09% 88.09% ======================================== Files 78 75 -3 Lines 4260 4260 ======================================== Hits 3753 3753 Misses 507 507 ``` | [Files](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [include/boost/http\_proto/serializer.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL3NlcmlhbGl6ZXIuaHBw) | `78.57% <100.00%> (+16.07%)` | :arrow_up: | | [src/serializer.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL3NlcmlhbGl6ZXIuY3Bw) | `74.89% <100.00%> (+2.37%)` | :arrow_up: | | [include/boost/http\_proto/impl/serializer.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ltcGwvc2VyaWFsaXplci5ocHA=) | `95.74% <94.44%> (-0.81%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [39a71bf...ef7098e](https://app.codecov.io/gh/cppalliance/http_proto/pull/74?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).
cppalliance-bot commented 6 months ago

GCOVR code coverage report https://74.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://74.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://74.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

ashtum commented 6 months ago

Decided to keep the source in the namespace, as moving it to a nested type of serializer would cause every source type to include serializer.hpp. Closes #70