cqfn / aibolit

Static Analyzer for Java Code with Machine Learning in Mind
https://pypi.org/project/aibolit/
51 stars 17 forks source link

Setter ignore for LCOM decomposition #618

Closed lyriccoder closed 4 years ago

lyriccoder commented 4 years ago

Please specify the following in the description:

  1. https://github.com/cqfn/aibolit/issues/617
  2. Now we can ignore setter in AST decomposition, if we want.

a) Setter pattern was written in a wrong way: it checked whether function name equals the filed name the following way: field bitMap, function setBitMap ->setter field bitMap, function setBlabla { this bitmap=0; } ->not a setter. It was fixed and new cases were found, like the following one:

  public void setRestrictSystemProperties(boolean val) {
    this.restrictSystemProps = val;
  }

It was found in a real example.

b) HybridConstructor module name was renamed. There was just a wrong name c) Some tests were added for AST decompostion with setters

lyriccoder commented 4 years ago

@acheshkov merge it

acheshkov commented 4 years ago

@rultor merge

acheshkov commented 4 years ago

@rultor hello

acheshkov commented 4 years ago

Test

lyriccoder commented 4 years ago

@acheshkov do it again pls. @rultor ignores you

acheshkov commented 4 years ago

@rultor merge

rultor commented 4 years ago

@rultor merge

@acheshkov OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 4 years ago

@rultor hello

@acheshkov Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)

rultor commented 4 years ago

@acheshkov do it again pls. @rultor ignores you

@lyriccoder I see you're talking about me, but I don't understand it. If you want to say something to me directly, start a message with @rultor

rultor commented 4 years ago

@rultor merge

@acheshkov Done! FYI, the full log is here (took me 45min)

rultor commented 4 years ago

@rultor merge

@acheshkov @lyriccoder The pull request is closed already, so I can't merge it