search

crabnebula-dev / devtools

Inspect and Debug your Tauri applications in style 💃
https://devtools.crabnebula.dev
Other
266 stars 8 forks source link

feat: add safari not support modal #310

Closed johann-crabnebula closed 3 months ago

johann-crabnebula commented 3 months ago

This PR adds a modal that will be displayed to all safari users notifying them that DevTools Web currently does not support safari:

Screenshot 2024-06-10 at 16 48 37

Closes DT-51

netlify[bot] commented 3 months ago

Deploy Preview for cn-devtools-app ready!

Name Link
Latest commit 96a9df376ab343ad20d7529434ed667ecca81a96
Latest deploy log https://app.netlify.com/sites/cn-devtools-app/deploys/6668feb7f692ec0008c8f2ea
Deploy Preview https://deploy-preview-310--cn-devtools-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alex-crabnebula commented 3 months ago

What is the point of dismissing the message? Wouldn't it be better to provide download links to different other browsers?

johann-crabnebula commented 3 months ago

Providing download links is a little savage haha.

From my point of view, this is just a nice way of still letting people proceed if they want to try. Since the modal might still be shown in some weird wrong context. (Someone faking their user agent or something weird like that). The modal can also be closed by clicking next to it.

The main problem is that the only thing that "breaks" DevTools right now is the weird behavior of Safari blocking requests to localhost.