search

crackededed / Xtra

Xtra is a Twitch player and browser for Android.
GNU Affero General Public License v3.0
1.16k stars 43 forks source link

Closed captions? #158

Open iuliandita opened 1 year ago

iuliandita commented 1 year ago

I love this app. Thank you for your work!

To my question, I don't know if this feature exists, and I'm just missing it… can we enable captions which are available on some streams, like prerecorded shows (Critical Role)?

Thanks a bunch!

crackededed commented 1 year ago

no it's not a feature at the moment

crackededed commented 1 year ago

added a button for this

iuliandita commented 1 year ago

added a button for this

Amazing! Thanks a bunch!

iuliandita commented 1 year ago

I downloaded the latest apk from the releases page, but I can't see the CC button... Am I missing something?

crackededed commented 1 year ago

I downloaded the latest apk from the releases page, but I can't see the CC button... Am I missing something?

check if it's enabled in Settings -> Player buttons -> Show subtitles button

iuliandita commented 1 year ago

It is enabled there. I also enabled it in the Player menu, but it doesn't show in either place... I am testing it on a past broadcast that has CCs, and they work with the standard Twitch app.

crackededed commented 1 year ago

do you want to share which vod it is? i've only tried it on critical role vods (and only while logged out if that makes any difference). also if it's a sub only vod do you have any other qualities than "Auto"?

iuliandita commented 1 year ago

I only use Twitch for CriticalRole, so that's what I tried as well (S3 episodes 42, 43...). I had to log in, though, the VODs are only available to subscribers... I do get all options for video quality. Does the button show only on VODs that have CCs?

crackededed commented 1 year ago

Does the button show only on VODs that have CCs?

yes.

so has it worked on any vod yet? i checked like 10 of the recent vods and they all have closed captions and the button shows up for me.

iuliandita commented 1 year ago

This vod has CC (tested with the official app), but I don't really see the button in Xtra: Screenshot_20230104-170812 Screenshot_20230104-171143

I downloaded the release from 2 days ago, just to be sure. Should I do a full cache/data clear?

iuliandita commented 1 year ago

Okay, so I cleared all cache and data, completely removed the app and reinstalled from the latest release. I still don't get the CC button. However, only if I am logged in. If not, the button shows, and it works like it should. EDIT: Oh, just noticed, that if I'm not logged in, I only get Auto for video quality.

crackededed commented 1 year ago

when logged in you can turn off: Settings -> Playback access token headers -> under Videos: Include GQL token. this should also work

iuliandita commented 1 year ago

GQL token was off. Enabling it makes no difference (that I can see). On sub only content, I still have Auto only for video quality. For other streams, I see all options (all this while logged off).