The Attempted Payments tab is showing the same order multiple times

[echantigny]

Description

When an order has multiple transactions that are not ending up in a "Paid" status, the order shows up multiple times in the Attempted Payments listing, once for each transaction. This should most likely be a "distinct" listing.

Steps to reproduce

1. Make multiple failed attempts to pay an order.

Additional info

• Craft version: Craft Pro 3.0.34
• PHP version: 7.2.4
• Database driver & version: MySQL 5.7.21
• Plugins & versions: 2.0.0-beta.14

[lukeholder]

This looks like payment has just been attempted multiple times, as for creating new orders, could the Moneris gateway plugin be dropping the order ID before re-saving it?

[eric-chantigny]

@lukeholder @andris-sevcenko

I think you are misunderstanding the issue. The "attempted payment" listing seems to show the same order multiple times when there's multiple tries to pay for that same order. I'm just saying that the listing should not show an order for each failed attempt, just display it once and it will be less confusing for the admin. I don't want to see a listing of failed attempt, I just want to see orders with (one or +) failed attempts if not paid for.

[lukeholder]

@eric-chantigny is this still an issue?

[eric-chantigny]

@lukeholder I will do some testing and I will get back to you soon

[echantigny]

@lukeholder Yes, it is still an issue as of 2.1.2.

Each one of these entries link to the exact same detail page, in which you can see both transactions. I really think that the listing query just needs a Distinct on it.

[andris-sevcenko]

@eric-chantigny Agreed. As with all things, it's just a tad more complicated than it would appear at a glance :) (https://github.com/craftcms/commerce/blob/develop/src/elements/db/OrderQuery.php#L810)

[andris-sevcenko]

Looking into this.

[echantigny]

@andris-sevcenko Thank you! I confirm that this change fixes the issue.