search

crashmoney / obsidian-typewriter

Typewriter is an Obsidian theme designed for a focused writing experience.
GNU General Public License v3.0
91 stars 17 forks source link

[BUG] Font size for new properties #36

Closed chrisk-7777 closed 9 months ago

chrisk-7777 commented 10 months ago

Describe the bug

Awesome theme!

Obsidian recently added a new feature called "properties".

This theme renders the font for these smaller than other themes, making it a tad difficult to read.

To Reproduce

Steps to reproduce the behavior:

  1. Enable Typewrite theme
  2. Add a new property and populate (this can be done with cmd + ;)
  3. Observe smaller size

Information

CleanShot 2023-11-20 at 19 58 15

Typewrite font size 0.688em

CleanShot 2023-11-20 at 19 59 50@2x

Default font size 0.875em

CleanShot 2023-11-20 at 19 59 35@2x

I'm happy to raise a PR, but digging in to the theme.css I couldn't find anything related to metadata, so I'm not 100% where the font size is coming in for this theme.

crashmoney commented 9 months ago

Hey @chrisk-7777, thanks so much for using the theme and the detailed bug report!

The issue turned out to just be Typewriter not having the --metadata-input-font-size variable available. I've since linked it to the --font-small variable, which was a design decision on my part to have the metadata legible but not overtaking the actual text. It's quite close to the default size of 0.875em, actually 😄

Hope this helps!

chrisk-7777 commented 9 months ago

Fantastic thank you!