Shouldn't gdk-event-button-state be a gdk-modifier-type instead of a :uint?

crategus / cl-cffi-gtk

cl-cffi-gtk is a Lisp binding to the GTK+ 3 library.

http://www.crategus.com/books/cl-cffi-gtk

146 stars 33 forks source link

Shouldn't gdk-event-button-state be a gdk-modifier-type instead of a :uint? #74

Closed Ambrevar closed 4 years ago

Ambrevar commented 4 years ago

In gdk.event-structures.lisp, the GdkEvent declares most state to be gdk-modifier-type. Except for the touch and button` states, but I don't understand why since they should also be a list of modifiers instead of a mask.

Is this a mistake?

crategus commented 4 years ago

You are right. Both implementations works, but it should be consistent. Therefore I have changed :uint to gdk-modifier-type at the approbriate places.