search

crazy-max / docker-qbittorrent

qBittorrent Docker image
MIT License
73 stars 15 forks source link

Fix sed not working #20

Closed Suika closed 3 years ago

Suika commented 3 years ago

sed \ will not work, \\ will. You need to escape the escape character, to escape the escape character. Not \, nor \\, but \.

crazy-max commented 3 years ago

Please split your PR. One to fix sed and another for WEBUI_PORT. Thanks.

Suika commented 3 years ago

Just accept this one, I'll push another one later because at this point I can't be bothered anymore. Frankly it took me far more time to try to figure out this PR splitting bullshit with commits that stack on each other than to find the problem, firgure it out and build/test it multiple times. And I still don't know how to split them to be each own PRs for each commit wihout another branch having... just killme.

Suika commented 3 years ago

Or just patch it directly since I don't care about attribution.