search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

windows: preflights and ssh permissions fix #4082

Closed cfergeau closed 8 months ago

cfergeau commented 8 months ago

This tries to improve some pain points I had while testing on Windows.

cfergeau commented 8 months ago

Needs more work/testing:

panic: Should not happen, empty description for fix 'check-administrator-user'

goroutine 1 [running]:
github.com/crc-org/crc/v2/pkg/crc/preflight.(*Check).doFix(0xc00079fa10?)
        /home/teuf/dev/crc/pkg/crc/preflight/preflight.go:72 +0x119
github.com/crc-org/crc/v2/pkg/crc/preflight.doFixPreflightChecks({0x2cb33b0, 0xc00021f770}, {0xc000489000?, 0x17, 0xc0004f12d9?}, 0x0)
        /home/teuf/dev/crc/pkg/crc/preflight/preflight.go:116 +0x110
github.com/crc-org/crc/v2/pkg/crc/preflight.SetupHost({0x2cb33b0, 0xc00021f770}, 0xb4?)
        /home/teuf/dev/crc/pkg/crc/preflight/preflight.go:174 +0x45
github.com/crc-org/crc/v2/cmd/crc/cmd.runSetup({0x22bc24014c?, 0xc00079fbb0?, 0xb49b97?})
        /home/teuf/dev/crc/cmd/crc/cmd/setup.go:69 +0x29c
github.com/crc-org/crc/v2/cmd/crc/cmd.glob..func10(0xc00013c000?, {0x4419348, 0x0, 0x0})
        /home/teuf/dev/crc/cmd/crc/cmd/setup.go:42 +0x5d
github.com/crc-org/crc/v2/cmd/crc/cmd.executeWithLogging.func1(0x3e701a0, {0x4419348, 0x0, 0x0})
        /home/teuf/dev/crc/cmd/crc/cmd/root.go:169 +0x102
github.com/spf13/cobra.(*Command).execute(0x3e701a0, {0x4419348, 0x0, 0x0})
        /home/teuf/dev/crc/vendor/github.com/spf13/cobra/command.go:983 +0xaaa
github.com/spf13/cobra.(*Command).ExecuteC(0x3e6fec0)
        /home/teuf/dev/crc/vendor/github.com/spf13/cobra/command.go:1115 +0x425
github.com/spf13/cobra.(*Command).Execute(...)
        /home/teuf/dev/crc/vendor/github.com/spf13/cobra/command.go:1039
github.com/spf13/cobra.(*Command).ExecuteContext(...)
        /home/teuf/dev/crc/vendor/github.com/spf13/cobra/command.go:1032
github.com/crc-org/crc/v2/cmd/crc/cmd.Execute()
        /home/teuf/dev/crc/cmd/crc/cmd/root.go:105 +0xd9
main.main()
        /home/teuf/dev/crc/cmd/crc/main.go:8 +0x17

/hold

cfergeau commented 8 months ago

/unhold

cfergeau commented 8 months ago

Needs more work/testing:

Fixed now.

gbraad commented 8 months ago

This tries to improve some pain points I had while testing on Windows.

Can you reference in future the issue this tries to solve?

cfergeau commented 8 months ago

This tries to improve some pain points I had while testing on Windows.

Can you reference in future the issue this tries to solve?

I've added "fixes https://github.com/crc-org/crc/issues/4079" to the 2nd commit log.

gbraad commented 8 months ago

OKD test now fails?

cfergeau commented 8 months ago

OKD test now fails?

Looks like a timeout of some sort.

openshift-ci[bot] commented 8 months ago

@cfergeau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 42262d66ac4fffcb7dfa44c9d322cc9c61afd4c1 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [anjannath,gbraad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment