search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Update to go-1.21 #4139

Closed praveenkumar closed 6 months ago

praveenkumar commented 6 months ago

/retest

cfergeau commented 6 months ago

mak echeck failed on Windows.

praveenkumar commented 6 months ago

make check failed on Windows.

@cfergeau only on windows-2019 and windows-2022 it is working as expected, I will check what's is happening there.

praveenkumar commented 6 months ago

Fwiw, we used to have a similar workaround https://github.com/crc-org/crc/commit/1b6bf222090f

Do you suggest that we should use a hack keep the windows-2019 runner job?

I don't know what "win-2022 also have OS-10.0.x build" means.

I took it that it have some similarity with win-10 but as per https://en.wikipedia.org/wiki/Windows_Server_2022

looks like codebase is different Windows Server 2022 is based on the "Iron" codebase.[5] Its updates are incompatible with the Windows 10 operating system, as the "Iron" codebase was not used for it.[5] Like its predecessor, Windows Server 2019, it requires x64 processors.

I think we can keep windows-2022 till it is working and remove it if that also starts failing because now we already have win-10/11 for e2e added as gh-action.

cfergeau commented 6 months ago

Fwiw, we used to have a similar workaround 1b6bf222090f

Do you suggest that we should use a hack keep the windows-2019 runner job?

I only mean that I don't find the argument "we need a workaround to keep the win2019 runners" very convincing when we already had a similar workaround in the past.

I think we can keep windows-2022 till it is working and remove it if that also starts failing because now we already have win-10/11 for e2e added as gh-action.

Fine with me, not even sure win2022 brings much as we have win10/win11 e2e?

praveenkumar commented 6 months ago

ack from me with the confusing "win-2022 also have OS-10.0.x build" removed from the commit log.

removed it from the commit message.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 6 months ago

I'd delay this after the next release though.

@cfergeau because of RHEL-8.10 still not out?

/hold

cfergeau commented 6 months ago

I'd delay this after the next release though.

@cfergeau because of RHEL-8.10 still not out?

/hold

In a more general way, we don't want to discover during the release that "something" was not ready for go 1.21. But yes, I think we do our linux release builds on a rhel8, so this is one good reason for waiting with this change.

openshift-ci[bot] commented 6 months ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 6 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7f1fb1b265eb2247f8dd2bfb41b347d2096192c6 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).