crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

nameservers: Use nmcli to update the nameserver and search info #4145

Closed praveenkumar closed 6 months ago

praveenkumar commented 6 months ago

From 4.15, because of ovn-kubernetes the info around nameserver and search option in the /etc/resolv.conf not match with user expectation. ovs-configuration service is run on this node which is a dependency for kubelet and this make changes in the networking by creating bridge network and restarting the NetworkManager. As soon as NM restart happen, changes which are done as part of crc vm post start are vanished.

This PR is going to make sure that changes are done using nmcli and shouldn't removed when NM restart happen. Following steps are done in this PR

Fixes: Issue #4144

openshift-ci[bot] commented 6 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security e8f5701ac5db409dd834522ea9731b4cda363973 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment