search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Enable arm64 builds for Linux #4162

Closed praveenkumar closed 4 months ago

praveenkumar commented 6 months ago

/hold

gbraad commented 5 months ago

Were other related issues addressed, like arm versions of the helper and driver?

praveenkumar commented 5 months ago

Were other related issues addressed, like arm versions of the helper and driver?

not yet, I will look into this again today, was destructed by 4.15 bundle creation and other issues.

cfergeau commented 5 months ago

was destructed by 4.15 bundle creation

Hopefully you were only distracted ;) ( https://en.wiktionary.org/wiki/destruct )

gbraad commented 5 months ago

What is the status of this overall? Seems this took a lot more effort than was anticipated.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 46df116e2599e87651b4bbfc2ea36aa460006b53 link false /test security
ci/prow/e2e-crc 46df116e2599e87651b4bbfc2ea36aa460006b53 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 4 months ago

/unhold