search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

add crc config set/get/unset preset test cases #4170

Closed lilyLuLiu closed 6 months ago

lilyLuLiu commented 6 months ago

Fixes: Issue #N

Relates to: PR #4167

Solution/Idea

Add test cases of setting, getting, and unsettling the preset property.

Proposed changes

List the main as well as consequential changes you introduced or had to introduce.

  1. Add positive cases for setting, getting, and unsettling the preset property.
  2. Add negative cases for setting preset property.

Testing

What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.

  1. e2e test cases
adrianriobo commented 6 months ago

Can we re arrange and create only one commit?,

there is no strict rules about it but I use to prefix these commits with [qe] (i.e [qe] add testing scenario to check preset configuration)

gbraad commented 6 months ago

Can we re arrange and create only one commit?,

@lilyLuLiu This can be done with a git rebase -i [commit ref] and the s (squash) option. The commit ref can be something like HEAD~2

lilyLuLiu commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 820e37a372017613e400493d407f47ce52aa35e2 link false /test security
ci/prow/integration-crc 820e37a372017613e400493d407f47ce52aa35e2 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/crc-org/crc/blob/main/test/OWNERS)~~ [adrianriobo,gbraad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment