crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

pkg: remove use of sudo from the signing script #4206

Closed anjannath closed 5 months ago

anjannath commented 5 months ago

this is required as use of 'sudo' is not available in downstream build machines. while testing the built pkg with this changes crc is working as expected

anjannath commented 5 months ago

/hold till it is tested by the downstream pipeline, cc @adrianriobo

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/v2.37/OWNERS)~~ [adrianriobo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anjannath commented 5 months ago

/cheery-pick main