search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

update image to centos:stream9 used for testing rpm build on ci #4210

Closed anjannath closed 5 months ago

anjannath commented 5 months ago

centos:stream8 has reached EOL as per: https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

fixes #4204

cfergeau commented 5 months ago

This needs more changes to avoid

  > [6/6] RUN yum config-manager --set-enabled powertools &&     yum -y builddep packaging/rpm/crc.spec &&     rpmbuild -bb -v packaging/rpm/crc.spec:
0.370 Error: No matching repo to modify: powertools.
anjannath commented 5 months ago

This needs more changes to avoid

  > [6/6] RUN yum config-manager --set-enabled powertools &&     yum -y builddep packaging/rpm/crc.spec &&     rpmbuild -bb -v packaging/rpm/crc.spec:
0.370 Error: No matching repo to modify: powertools.

yes updated now, the powertools repo is not available in centos9 have to use the repo crb

anjannath commented 5 months ago

@cfergeau another question which is not directly related but the tests in the machine-driver-libvirt repo is also failing due to same centos:stream8 reaching EOL

but can we build machine-driver-libvirt on Centos Stream 9 and use it in RHEL 8, in the past there were issues with this because the glibc version is newer in RHEL 9/Centos Stream 9. how can we check if this is still the case?

openshift-ci[bot] commented 5 months ago

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc d47c071cc7d479c497bcb048eba5144710861183 link true /test e2e-crc
ci/prow/security 6ce70293015a80c79fe478b5bc1eaf51c28e28c7 link false /test security
ci/prow/integration-crc 6ce70293015a80c79fe478b5bc1eaf51c28e28c7 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cfergeau commented 5 months ago

but can we build machine-driver-libvirt on Centos Stream 9 and use it in RHEL 8, in the past there were issues with this because the glibc version is newer in RHEL 9/Centos Stream 9. how can we check if this is still the case?

This most likely is still an issue, you can build machine-driver-libvirt in centos stream 9 and then try to start the resulting binary in an ubi8 image for example.

However, the binary that we ship is built on a rhel 8 system in RH build system, so the centos version we use in our Containerfiles should not be a problem?

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment