creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
104 stars 137 forks source link

Remove Hotjar-related packages and code #372

Closed brylie closed 2 years ago

brylie commented 2 years ago

We currently include two packages related to Hotjar in package.json and some analytics code throughout our components. However, the Hotjar code may no longer be necessary since we are not actively using Hotjar analytics for any internal measurements.

Task

clasick commented 2 years ago

@brylie Went through the code and can't seem to find the Hotjar-related in the components nor the package.json. Has this task already been resolved or am I looking in the wrong place... 😕

sadn1ck commented 2 years ago

yeah @clasick looks like it already has been removed

brylie commented 2 years ago

Ah, this should have been opened in the Chooser repository. My bad.

sadn1ck commented 2 years ago

@clasick you can work on this, now that the confusion has been cleared! 😃

clasick commented 2 years ago

@brylie Thanks for the clarification!

@clasick you can work on this, now that the confusion has been cleared! 😃

Yup, I've started on a fix for this. ✌️

brylie commented 2 years ago

When running npm install, I see the following warning:

vue-analytics@5.22.1: Sorry but vue-analytics is no longer maintained. I would suggest you switch to vue-gtag, with love, the guy who made the package.

I think we should just remove the analytics code entirely, and not use vue-gtag as suggested. Just adding a note here.

brylie commented 2 years ago

@clasick, any update on this task?

yaya-usman commented 2 years ago

@brylie Hi, i think i should give this a try, can i get assigned this?

brylie commented 2 years ago

Sure thing, @yaya-usman. I'll assign you.

yaya-usman commented 2 years ago

Sure thing, @yaya-usman. I'll assign you.

Thanks

MuluhGodson commented 2 years ago

Good Housekeeping Closed by #391