search

creativecommons / quantifying

quantify the size and diversity of the commons--the collection of works that are openly licensed or in the public domain
MIT License
22 stars 30 forks source link

ADDED: [Feature] GitHub Repository Tracking #106

Closed IamMQaisar closed 3 months ago

IamMQaisar commented 3 months ago

Fixes

Fixes #99 by @Darylgolden

Description

Added github_scratcher.py to now track the total number of repositories on GitHub that utilize Creative Commons licenses of all types.

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
Darylgolden commented 3 months ago

Hey @IamMQaisar, I'm not sure if you missed it but I've already started working on a PR fixing this at #101. Sorry that it's taking a while for me to respond to the reviews as I'm busy with other things IRL.

IamMQaisar commented 3 months ago

Hi @Darylgolden , Yes Brother, I know that you are working on the PR and this PR of mine was just to fast track and ommit the errors as well as to correlate with the latest changes of the codebase mergers.

You may eventually bring out the changes of files, from my PR to your and make your PR better/complete so that @TimidRobot has ease in merging the PR rather than us being waiting that he mentions all the changes themselve and then we make those changes. Which will only delay the process and make the maintainer go through and mention everything manually.

Darylgolden commented 3 months ago

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR. Creating a competing PR makes the attribution of changes unclear and feels like it creates a sense of competition rather than collaboration, even if that was not your intention. Also, for a open source project, I don't think a 3 day wait from a review is that long to necessitate superseding another PR. I would have understood if it was stale for a week or longer.

TimidRobot commented 3 months ago

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR. Creating a competing PR makes the attribution of changes unclear and feels like it creates a sense of competition rather than collaboration, even if that was not your intention. Also, for a open source project, I don't think a 3 day wait from a review is that long to necessitate superseding another PR. I would have understood if it was stale for a week or longer.

Agreed.

IamMQaisar commented 3 months ago

Sure, I'll take that into account and make it more collaborative next time by doing a PR into the existing PR of others.

IamMQaisar commented 3 months ago

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR.

I am unable to fork your repo, as it's probably not enabled to be forked. Can you enable it so that I can fork and work on it?

Darylgolden commented 3 months ago

@IamMQaisar I believe it's enabled by default. What problems do you get when you attempt to fork?

IamMQaisar commented 3 months ago

Let me show you in a while.

IamMQaisar commented 3 months ago

image