creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
19 stars 114 forks source link

[Bug] Menu Button Non-Functional on Lower Screen Widths #241

Closed mo-gbolahan closed 1 month ago

mo-gbolahan commented 1 month ago

Description

When the screen width is reduced (e.g., on mobile or small window sizes), a menu button appears as expected. However, clicking on the button does not trigger any action, and the button is not referenced in the JavaScript file for any event handling. This results in a broken user interface, as users cannot access the menu in smaller viewports.

Reproduction

  1. Reduce the screen width (e.g., resize browser window or use a mobile device).
  2. Observe the menu button appearing in place of the usual navigation bar.
  3. Click the menu button.
  4. Notice that no action is triggered upon clicking the button.

Expectation

Clicking the menu button should toggle a responsive menu (e.g., sliding out or displaying menu options), allowing users to navigate the site in smaller viewports.

Screenshots

Screenshot (26) The button is circle in red

Actual Behavior

Clicking the button does nothing. Upon reviewing the code, it appears that the menu button is not linked to any event handler in the JavaScript file, rendering it non-functional.

Suggested Resolution

Since there is no hidden menu on larger screen sizes that the menu button is meant to toggle on smaller screens, I recommend removing the button entirely. This will avoid confusion and improve the user experience on smaller viewports.

possumbilities commented 1 month ago

Hi @mo-gbolahan and thanks for this contribution!

This is a duplicate of #237 Please verify Issues don't already exist before creating new ones.

Please see the Contribution Guidelines

Closing as duplicate.