creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
19 stars 114 forks source link

Empty span tag in index.html removed #281

Closed SisiVero closed 1 month ago

SisiVero commented 1 month ago

Fixes

Description

This PR addresses the issue of an empty span tag.

Tests

Th span tag has been removed/deleted.

Checklist

netlify[bot] commented 1 month ago

Deploy Preview for cc-search-portal ready!

Name Link
Latest commit f418e08f805d051714311465b769100f89755355
Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6706bad58aa1cd0008213a34
Deploy Preview https://deploy-preview-281--cc-search-portal.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

possumbilities commented 1 month ago

Closing, please see original Issue as to why. You did good work, this was just a mistake on my part:

Apologies, I misread this. The span here has a purpose, which is to allow a placeable spot for the "skip to content" link to target within the markup. As spans are semantically meaningless it can be present and empty while serving this function. Its function here is a requirement for adequate Accessibility.

Now that I've revisited it, this should have been closed. Thanks for understanding, sorry for the confusion.