[Feature] Use docker compose version 2 (non swarm deployment) - Githubissues

creativecommons / wp-plugin-creativecommons

Official Creative Commons plugin for licensing your content. With Creative Commons licenses, keep your copyright AND share your creativity.

https://wordpress.org/plugins/creative-commons/

GNU General Public License v2.0

154 stars 104 forks source link

[Feature] Use docker compose version 2 (non swarm deployment) #232

Closed TimidRobot closed 7 months ago

TimidRobot commented 7 months ago

Description

Docker compose version is currently 3, but that is for swarm mode.

Reproduction

https://github.com/creativecommons/wp-plugin-creativecommons/blob/04572379610190d355cd64ecacd3d4ab4c7c6156/dev/docker-compose.yml#L1

Expectation

Best version for our use

Additional context

Compose file version 3 reference:
⚠️ Looking for options to set resources on non swarm mode containers?

The options described here are specific to the deploy key and swarm mode. If you want to set resource constraints on non swarm deployments, use Compose file format version 2 CPU, memory, and other resource options. If you have further questions, refer to the discussion on the GitHub issue docker/compose/4513. [emphasis added]
- https://github.com/docker/compose/issues/4513#issuecomment-281478365
  
  Are we just expected to stay on v2.1 if we want to use docker-compose and not swarm mode?
Yes.
- https://github.com/docker/compose/issues/4513#issuecomment-289620945 Yes, we will continue to maintain and add to the v2 format for the foreseeable future. The hope is that in time, the v3 format + docker stack will be an equivalent or even better solution for most use-cases and that everyone will want to use it, but we know we have a long way to go until we get there.
Compose file version 2 reference

Resolution

[x] I would be interested in resolving this bug.