creativetimofficial / ct-argon-dashboard-pro-react

13 stars 7 forks source link

[Bug] Documentation Incorrect #49

Closed kvjoshi closed 2 years ago

kvjoshi commented 2 years ago

Version

1.2.1

Reproduction link

https://demos.creative-tim.com/argon-dashboard-pro-react/#/documentation/quick-start

Operating System

Windows 10

Device

PC

Browser & Version

Firefox Dev Edition v97

Steps to reproduce

Nothing To reproduce , There is some mistake or misinterpretation in the Docs, when making a CRA and importing the assets, not all the assets mentioned in the Docs are present in the assets/vendor folder except nucleo. instead all the assets are imported from node_modules.

What is expected?

// plugins styles from node_modules import "react-notification-alert/dist/animate.css"; import "react-perfect-scrollbar/dist/css/styles.css"; import "@fullcalendar/common/main.min.css"; import "@fullcalendar/daygrid/main.min.css"; import "sweetalert2/dist/sweetalert2.min.css"; import "select2/dist/css/select2.min.css"; import "quill/dist/quill.core.css"; import "@fortawesome/fontawesome-free/css/all.min.css"; // plugins styles downloaded import "assets/vendor/nucleo/css/nucleo.css"; // core styles import "assets/scss/argon-dashboard-pro-react.scss?v1.2.0";

What is actually happening?

// plugins styles from node_modules import "react-notification-alert/dist/animate.css"; // plugins styles downloaded import "assets/vendor/fullcalendar/dist/fullcalendar.min.css"; import "assets/vendor/sweetalert2/dist/sweetalert2.min.css"; import "assets/vendor/select2/dist/css/select2.min.css"; import "assets/vendor/quill/dist/quill.core.css"; import "assets/vendor/nucleo/css/nucleo.css"; import "assets/vendor/@fortawesome/fontawesome-free/css/all.min.css"; // core styles import "layouts/Documentation/assets-for-demo/docs.scss"; import "layouts/Documentation/assets-for-demo/react-docs.scss"; import "assets/scss/argon-dashboard-pro-react.scss";


Solution

// plugins styles from node_modules import "react-notification-alert/dist/animate.css"; import "react-perfect-scrollbar/dist/css/styles.css"; import "@fullcalendar/common/main.min.css"; import "@fullcalendar/daygrid/main.min.css"; import "sweetalert2/dist/sweetalert2.min.css"; import "select2/dist/css/select2.min.css"; import "quill/dist/quill.core.css"; import "@fortawesome/fontawesome-free/css/all.min.css"; // plugins styles downloaded import "assets/vendor/nucleo/css/nucleo.css"; // core styles import "assets/scss/argon-dashboard-pro-react.scss?v1.2.0";

Additional comments

or please specify if the plugins are installed manually instead of from NPM use the following , or use similar to what is done in importing react-notification-alert