crisbusquets / uifrommars-five

uiFromMars' WordPress theme
https://www.uifrommars.com/
0 stars 0 forks source link

Format php files #1

Closed aasensios closed 6 months ago

aasensios commented 6 months ago

To make the code style across the PHP files more consistent and lean, I've used the VSCode extension PHP Intelephense.

Also, to have consistency with the rest of CSS and JS files, I've applied 2 spaces for the tab size (instead of 4) to the PHP files.

This code style is being ensured by the files extensions.json and settings.json, under the .vscode directory in the root level of this project.

As a bonus, you'll see that I've added the useful VSCode extension Spell Checker as a recommended one in the extensions.json, enabled for both English and Spanish. That way we'll catch typos easily 🤓

Since I'm not able to test these changes locally due to some issues with WP Local, please pull this branch and check that I didn't break anything (😅 🙏🏼):

git switch refactor/format-php-files

When done, just switch back to the main branch and delete mine:

git switch main
git branch -D refactor/format-php-files

If you see everything ok, you can merge this pull request, wait for the auto-deployment to finish via the GitHub action, and finally clear the cache from WordPress CMS 🤣