search

criteo-cookbooks / ms_dotnet

Chef Cookbook to install Microsoft .NET
Apache License 2.0
17 stars 19 forks source link

Remove Foodcritic in favor of Cookstyle #107

Closed jakauppila closed 2 years ago

jakauppila commented 2 years ago

Foodcritic has been deprecated in favor of Cookstyle, so removed any references to Foodcritic, added tests for Cookstyle, and auto-corrected all Cookstyle syntax issues.

jakauppila commented 2 years ago

@Annih I'm assuming there's some manual steps required to get these kitchen converges to fire?

image

Annih commented 2 years ago

As for windows we are using EC2 kitchen boxes, PR coming from external repositories have to deploy their own secrets; I'll validate your PR manually.

jakauppila commented 2 years ago

@Annih Fixed that issue. If you're interested I could cut a separate PR to move the kitchen executions to run via Github actions on the public runners.

jakauppila commented 2 years ago

@Annih Just wanted to ping on this again.

Annih commented 2 years ago

OK thank you @jakauppila for the change and sorry for the delay.

Feel free to push a new PR for the kitchen suite on public GA runners.